Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/DistinctStructFiles #34

Merged
merged 5 commits into from
Dec 18, 2018
Merged

Feature/DistinctStructFiles #34

merged 5 commits into from
Dec 18, 2018

Conversation

sshort
Copy link
Contributor

@sshort sshort commented Dec 18, 2018 •
edited
Loading

Potential fix for #33

  • Updated to create Struct files in Java package name that matches the object path. (Pushed down a level compared to the current implementation)
  • Added some logging and logback dependencies

@sshort sshort changed the title Feature/inno 147 Feature/DistinctStructFiles Dec 18, 2018
@hypfvieh
Copy link
Owner

Thanks for your PR.
The CreateInterface definitely needs some love - it's still in the same condition as it was in the original version of dbus-java.
I'm not using this tool, so I did not spend much time on improving it.

@hypfvieh hypfvieh merged commit 0d0c937 into hypfvieh:master Dec 18, 2018
@sshort
Copy link
Contributor Author

sshort commented Dec 19, 2018

FYI I don't think this is sufficient to fix the problem. It's broken with or without this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshort @hypfvieh